Skip to content

docs(scient): definition of done and review line in the PR template - #70

Merged
yaacovcorcos merged 4 commits into
mainfrom
claude/work-rules-20261117
Nov 17, 2026
Merged

yaacovcorcos merged 4 commits into
mainfrom
claude/work-rules-20261117

Conversation

@yaacovcorcos

@yaacovcorcos yaacovcorcos commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

What

A short Definition of done for Scient Agent, written into Scient's own file (SCIENT.md), following this repository's rule to keep Scient's changes apart:

  • bun check, the focused tests and the Scient checks the change touches pass;
  • a change to a page or screen the agent shows (sign-in pages, the stats dashboard, the terminal) has before/after screenshots, checked against Scient Desktop's UI checklist;
  • every followable link the change adds was fetched once;
  • the PR states what ran on macOS, Linux and Windows, and names its review and result;
  • the allowed delivery is complete. Merge only when authorized, on the reviewed head, after gh pr checks shows every job green, CI passed included, which main requires since ci: require one passing check on main; let Dependabot update only Scient's actions #69. An unrelated failed job is rerun once, then reported.

Two small marked scient(SA-POLICY) hooks in Oh My Pi files: one sentence in the existing AGENTS.md block pointing at the new section, and two fields (Platforms, Review) in the PR template. The SA-POLICY ledger contract now mentions the definition of done.

Why

The same rules are being added to Scient Desktop (ScientFactory/scient-desktop#977). Agent work was reported finished without platform notes, review records or link checks, and merges need an explicit "green before merge" step.

Testing

  • bun scripts/scient/divergence-check.ts --footprint: every divergence accounted for. SA-POLICY grows by one AGENTS.md sentence and a 10-line template block; the template needs a place for the PR to record platforms and review.
  • git diff --check clean. Docs only: no code, build or test change.

Platforms

Docs and template only, so behavior is the same on macOS, Linux and Windows; nothing to run per platform.

Review

Review: Claude Fable 5.2 (high) and Codex gpt-6.1-sol (high), independent and read-only: 26 findings across both repos, 24 accepted. One recheck by both: 9 findings, all accepted.


  • bun check passes (no TypeScript or Rust changed; divergence check run)
  • Tested locally (docs only)
  • CHANGELOG updated (not user-facing)

Merge order: merge ScientFactory/scient-desktop#977 first. The UI-checklist link in SCIENT.md points at a section that PR adds.

Model/harness: Claude Opus 5.5 / Claude Code (Scient).

🤖 Generated with Claude Code

@yaacovcorcos
yaacovcorcos force-pushed the claude/work-rules-20261117 branch 2 times, most recently from 84b711b to a8a07a0 Compare November 17, 2026 11:53
yaacovcorcos and others added 4 commits November 17, 2026 15:54
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…done

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@yaacovcorcos
yaacovcorcos force-pushed the claude/work-rules-20261117 branch from a8a07a0 to 2d881f3 Compare November 17, 2026 13:54
@yaacovcorcos
yaacovcorcos merged commit ec7f0b5 into main Nov 17, 2026
22 checks passed
@yaacovcorcos
yaacovcorcos deleted the claude/work-rules-20261117 branch November 17, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant